AntFleet

Disagreement · 0982a39f-anthropic-2

inspect-* scripts crash with confusing error when env vars are missing

mismatch
repo e24ef98c·PR #6·reviewed 2 weeks ago

Primary finding

inspect-* scripts crash with confusing error when env vars are missing

lowmaintainabilityhigh
  • apps/web/scripts/inspect-app-hook.ts:22-26
  • apps/web/scripts/inspect-app.ts:19-23
The `!` non-null assertions coerce undefined env vars into `undefined`, which is then passed to createAppAuth. The resulting error from @octokit/auth-app is not obviously about a missing env var, making the script harder to use for operators. Doc comment says these are read from .env.local — when that file is missing, the error should say so. Minor operator-UX issue in admin tooling.

Recommendation

Add explicit guards: `if (!process.env.GITHUB_APP_ID || !process.env.GITHUB_APP_PRIVATE_KEY) { console.error('Missing GITHUB_APP_ID / GITHUB_APP_PRIVATE_KEY in .env.local'); process.exit(1); }`.

Counterpart finding

Admin scripts lack validation for required environment variables and fail with opaque errors when unset

lowapi-contracthigh
  • apps/web/scripts/inspect-app-hook.ts:21-24
  • apps/web/scripts/inspect-app.ts:20-23
  • apps/web/scripts/inspect-finding-status.ts:12-18
Both GitHub App scripts use non-null assertions on critical env vars without verifying presence before use, and the DB inspection script relies on DATABASE_URL but does not validate it. When missing, these scripts will throw inside library code, producing less actionable errors.

Recommendation

Add explicit early checks with clear error messages and non-zero exits when required env vars are missing, e.g., validate GITHUB_APP_ID and GITHUB_APP_PRIVATE_KEY in the GitHub App scripts, and DATABASE_URL before importing/using the DB layer.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗