Disagreement · 09a05e58-anthropic-4

Network classification only treats exact 'base' as mainnet; sepolia detection by negation hides config bugs

solo Opus

repo 5149da9d·PR #1·reviewed 2 days ago

Opus finding

Network classification only treats exact 'base' as mainnet; sepolia detection by negation hides config bugs

lowbugmedium

desktop/renderer/src/components/wallet/WalletSidebarPanel.tsx:102-113
desktop/renderer/src/components/wallet/WalletView.tsx:78-80

Any network string other than the literal `"base"` (including `null`, an empty string, or a misconfigured value such as `"base-mainnet"`) is silently treated as Base Sepolia testnet. This includes the explorer URL (links to wrong network) and the TESTNET label. If the backend ever changes the network identifier (e.g., to `base-mainnet`), users will be sent to the wrong block explorer and see incorrect network badges — a subtle data-integrity issue.

Recommendation

Whitelist known network identifiers and render an unknown-network branch explicitly, or centralize the mapping in one helper used by both sidebar/view/explorer URLs.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreements view public receipts see unanimous findings + anatomies →

Tweet ↗