AntFleet

Disagreement · 09a05e58-anthropic-5

wallet-store exposes setConfig but WalletView keeps walletConfig in local state

solo Opus
repo 5149da9d·PR #1·reviewed 2 days ago

Opus finding

wallet-store exposes setConfig but WalletView keeps walletConfig in local state

lowmaintainabilityhigh
  • desktop/renderer/src/stores/wallet-store.ts:41-49
  • desktop/renderer/src/components/wallet/WalletView.tsx:134-135
The store defines `config` and `setConfig` specifically for wallet config, but WalletView never uses them — it duplicates the same data in local React state via `useState<WalletConfig | null>`. The sidebar and any other consumers that wanted to read caps (e.g., session/per-tx caps) cannot, because the store stays `null`. This is both a maintainability issue (dead API surface) and a real functional gap (sidebar can't show caps even though the model supports it).

Recommendation

Either remove `config`/`setConfig` from the store or have WalletView call `setConfig(configRes)` instead of (or in addition to) the local useState.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗