AntFleet

Disagreement · 09a05e58-openai-0

Wallet disabled state does not clear stale wallet data, causing incorrect UI when previously connected

solo GPT-5
repo 5149da9d·PR #1·reviewed 2 days ago

GPT-5 finding

Wallet disabled state does not clear stale wallet data, causing incorrect UI when previously connected

mediumbughigh
  • desktop/renderer/src/components/wallet/WalletView.tsx
  • desktop/renderer/src/components/wallet/WalletView.tsx
When wallet.getConfig reports disabled, refresh() returns early after setFailReason("disabled") without clearing address/balances/transactions in the store. If a prior session had set a non-null address, the UI condition (!address && !loading && failReason) is false and the normal wallet UI renders with stale data, contradicting the disabled state.

Recommendation

On the disabled path in refresh(), clear wallet state so the UI reflects the disabled status. For example, call the store’s reset() or explicitly set address to null, balances to [], and transactions to []. Also gate actions on config.enabled if needed.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗