AntFleet

Disagreement · 11ac0e29-openai-4

Route params typed as Promise and awaited; API signature mismatch

solo GPT-5
repo 6f7fc663·PR #26·reviewed 1 week ago

GPT-5 finding

Route params typed as Promise and awaited; API signature mismatch

lowapi-contracthigh
  • dashboard/app/api/runs/[id]/logs/route.ts:24-31
In Next.js App Router, params is a plain object, not a Promise. Typing it as Promise and awaiting it works at runtime (await on non-Promise is a no-op) but is misleading and could mask future errors.

Recommendation

Use the canonical signature: export async function GET(_req: Request, { params }: { params: { id: string } }). Remove await params.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →