AntFleet

Disagreement · 1a8e53aa-anthropic-2

`var` parsing strips `dry-run` prefix but spec is ambiguous about whitespace/separator

mismatch
repo 6f7fc663·PR #21·reviewed 1 week ago

Primary finding

`var` parsing strips `dry-run` prefix but spec is ambiguous about whitespace/separator

lowapi-contractmedium
  • skills/contributor-spotlight/SKILL.md:85-89
  • skills/contributor-spotlight/SKILL.md:7
The regex `^dry-run` matches `dry-run`, `dry-runs`, `dry-runfoo`, and `dry-run owner/repo`. After stripping the prefix, the remainder for `dry-runs` is `s`, which fails the owner/repo regex → `OVERRIDE_FORK=auto`. But for `dry-runowner/repo` (no separator) the remainder is `owner/repo` and is silently treated as an override — which is probably not intended. Also, in the third bullet `OVERRIDE_FORK=$var` references `$var` not the *remaining* var, which after the strip would re-include `dry-run`. The bullet should say `OVERRIDE_FORK=$remaining_var`. This is a small but real spec bug that will produce confusing behavior when the implementing agent follows the literal text.

Recommendation

Tighten the regex to `^dry-run($|[[:space:]])` and explicitly require a separator. Fix the third bullet to reference `$remaining_var` (the post-strip value). Document the canonical forms: `dry-run`, `dry-run owner/repo`, `owner/repo`.

Counterpart finding

Commit count underreports for very active forks due to missing pagination (per_page=100)

lowbughigh
  • skills/contributor-spotlight/SKILL.md:93-94
The commits list endpoint is paginated. Counting only the first page caps at 100, potentially underreporting commit activity for highly active forks.

Recommendation

Either paginate (follow Link headers to aggregate counts) or switch to an endpoint that summarizes commit activity (e.g., /stats/commit_activity) and derive a 30-day total, with retry/backoff for 202 responses.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →