AntFleet

Disagreement · 1e8fb4a1-openai-1

BaseHook inherits ImmutableState but does not pass required PoolManager constructor argument, causing compilation/deployment failure

solo GPT-5
repo a7cc2ed7·PR #1·reviewed 1 week ago

GPT-5 finding

BaseHook inherits ImmutableState but does not pass required PoolManager constructor argument, causing compilation/deployment failure

highbuild-releasehigh
  • src/base/BaseHook.sol
ImmutableState’s constructor requires an IPoolManager address. BaseHook defines a constructor but does not pass the required parameter to the ImmutableState base constructor. This will not compile or, if made to compile via testing tricks, would set poolManager to zero and make onlyPoolManager unusable at runtime.

Recommendation

Update BaseHook’s constructor to accept and forward an IPoolManager to ImmutableState, e.g.: constructor(IPoolManager _poolManager) ImmutableState(_poolManager) { validateHookAddress(this); }

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →