AntFleet

Disagreement · 1e8fb4a1-openai-4

updateBeneficiary allows transferring shares to the zero address, making future fee claims impossible (funds stranded)

solo GPT-5
repo a7cc2ed7·PR #1·reviewed 1 week ago

GPT-5 finding

updateBeneficiary allows transferring shares to the zero address, making future fee claims impossible (funds stranded)

highapi-contracthigh
  • src/base/FeesManager.sol
There is no validation preventing newBeneficiary from being address(0). If set to zero, only the zero address can claim fees, which is impossible. Shares become unclaimable and accumulate permanently, effectively stranding funds associated with those shares.

Recommendation

Add a require(newBeneficiary != address(0)) check (using a custom error if desired) and consider preventing transfer to contracts lacking fee-collection capability if that’s a concern.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →