AntFleet

Disagreement · 2385fc2f-anthropic-0

RSS feed omits required <pubDate> when closedAt is filtered but item still requires non-null pubDate — type narrowing OK, but no fallback if all items filtered

solo Opus
repo e24ef98c·PR #4·reviewed 2 weeks ago

Opus finding

RSS feed omits required <pubDate> when closedAt is filtered but item still requires non-null pubDate — type narrowing OK, but no fallback if all items filtered

lowmaintainabilitymedium
  • apps/web/app/receipts.rss/route.ts:18-27
The filter silently drops rows with closedAt === null. For a 'public receipts' feed where rows are gated by being closed, this is likely defensive — but the feed could end up empty (200 with zero items) while the page still shows totals. Not a bug per se, just a silent divergence between the page count and the feed count.

Recommendation

Either guarantee at the query layer that public-receipts rows always have a non-null closedAt, or document/log when the filter drops rows.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →