AntFleet

Disagreement · 24879b45-anthropic-5

extractFindingAtIndex returns wrong-finding fallback silently when JSON shape mismatches

solo Opus
repo e24ef98c·PR #10·reviewed 1 week ago

Opus finding

extractFindingAtIndex returns wrong-finding fallback silently when JSON shape mismatches

lowbugmedium
  • apps/web/lib/receipts.ts:245-270
toDisplayReceiptDetail falls back to a synthesized {severity, category, title, reasoning: null, recommendation: null, evidence: []} when extraction fails. This means a detail page may quietly show 'no reasoning/recommendation/evidence' even though the data does exist but the shape changed (schema_version skew). No log line is emitted on the fallback path, so silent data degradation is undetectable from telemetry.

Recommendation

Log a warning when extractFindingAtIndex returns null so schema-version drift is observable, even though the page still renders.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →