AntFleet

Disagreement · 24879b45-openai-1

Misleading comment and incorrect typing: searchParams is not a Promise in Next.js App Router

solo GPT-5
repo e24ef98c·PR #10·reviewed 1 week ago

GPT-5 finding

Misleading comment and incorrect typing: searchParams is not a Promise in Next.js App Router

lowdocs-gaphigh
  • apps/web/app/receipts/page.tsx:38-41
  • apps/web/app/receipts/page.tsx:44-49
In Next.js App Router, page components receive searchParams as a plain object, not a Promise. Awaiting a non-Promise value works at runtime but the comment is incorrect and the prop type is misleading. This can confuse maintainers and cause friction when adopting official Next.js types or tooling that expects the correct signature.

Recommendation

Update the comment and types: - Change the prop type to { searchParams: SearchParams } (object, not Promise) - Remove the unnecessary await and use const params = searchParams; - Adjust the comment to reflect the correct contract. This keeps typings aligned with Next.js and avoids confusion.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →