AntFleet

Disagreement · 3c2fcd11-openai-1

Skill hardcodes upstream repo (non‑portable, contradicts “live repo state”)

solo GPT-5
repo 6f7fc663·PR #9·reviewed 1 week ago

GPT-5 finding

Skill hardcodes upstream repo (non‑portable, contradicts “live repo state”)

mediummaintainabilityhigh
  • skills/show-hn-draft/SKILL.md
  • skills/show-hn-draft/SKILL.md
  • skills/show-hn-draft/SKILL.md
The skill claims to draft from the live repo state but fetches stars/forks from a hardcoded upstream path and embeds a hardcoded repo URL in the output. In forks or renamed repos, this produces incorrect stats and links, undermining the draft’s accuracy and reusability.

Recommendation

Resolve owner/repo dynamically (e.g., from $GITHUB_REPOSITORY in Actions or by reading git remote.origin.url). Use that for both gh api and the output link/one‑liner. Optionally allow an override via var. Fall back to upstream only if dynamically determining the repo fails, and clearly footnote when using fallback.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.