GPT-5 finding
v4-readiness manifest references files not included in the skill’s read set, causing missed Review detections
highbughigh
- skills/v4-readiness/SKILL.md
- skills/v4-readiness/SKILL.md
- skills/v4-readiness/SKILL.md
The skill promises to detect Review-pattern usage by scanning the fork’s inputs, but its declared input set excludes several locations explicitly listed in the Manifest (mcp-server/src/index.ts, .outputs/, chain-runner.yml, dashboard/). As a result, forks using those patterns will not be detected and will yield undercounted Review items or an incorrect READY verdict. This directly undermines the feature’s purpose of pre-upgrade risk surfacing.
Recommendation
Align the read set with the Manifest or narrow the Manifest to only patterns actually scanned. Concretely: (1) Add optional reads for mcp-server/src/index.ts, chain-runner.yml, .outputs/, and dashboard/* in both local and remote modes; (2) If these inputs are missing, mark the audit as PARTIAL and annotate which Review buckets were not scanned; (3) Until implemented, move those patterns to a clearly labeled "Not scanned in this version" section to avoid false assurance.