AntFleet

Disagreement · 4ff82c7b-anthropic-1

Worker reports kind:'done' with agreedCount=0/degraded=false even when the bundle has agreed findings or was degraded

solo Opus
repo e24ef98c·PR #11·reviewed 1 week ago

Opus finding

Worker reports kind:'done' with agreedCount=0/degraded=false even when the bundle has agreed findings or was degraded

mediumbughigh
  • apps/web/lib/review-worker.ts:168-174
  • apps/web/lib/review-worker.ts:50-54
The WorkerOutcome type advertises `agreedCount` and `degraded` on the done variant so callers (webhook, retry cron, logging, future observability) can record what actually happened. The implementation hard-codes 0 and false regardless of the bundle outcome. processClaimedRow has the bundle locally but does not return it, so the values are lost. This is deceptive: dashboards/logs that key off `outcome.agreedCount` or `outcome.degraded` will report every successful review as 0-findings, non-degraded. It also masks the no-files-skipped path vs a real review with findings.

Recommendation

Have processClaimedRow return the bundle summary (or null when skipped due to no files) and propagate `agreed.length` and `degraded` into the returned WorkerOutcome. Add a test asserting agreedCount and degraded propagate.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →