AntFleet

Disagreement · 528e46ce-anthropic-8

RSS lastBuildDate falls back to `new Date()` (now) instead of a stable value when both source streams are empty — breaks 304 caching downstream

solo Opus
repo e24ef98c·PR #10·reviewed 1 week ago

Opus finding

RSS lastBuildDate falls back to `new Date()` (now) instead of a stable value when both source streams are empty — breaks 304 caching downstream

lowmaintainabilitymedium
  • apps/web/app/receipts.rss/route.ts:51-62
If both newestSameRepo and newestCrossRepo are null (no public receipts and no merged outgoing PRs), lastBuildDate becomes the current request time. Combined with Cache-Control public/s-maxage=300, RSS readers that key off lastBuildDate may see a feed that mutates every 5 minutes despite having zero items — wasted polls, noise in cache layers. Minor.

Recommendation

Use a fixed epoch (e.g. new Date(0)) or the feed-launch date when both sources are empty.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗