AntFleet

Disagreement · 52c1a3b9-anthropic-3

Skipped-by-no-reviewable-files path bypasses comment-already-posted idempotency for a row that prior succeeded with comment but lost cache

solo Opus
repo e24ef98c·PR #11·reviewed 1 week ago

Opus finding

Skipped-by-no-reviewable-files path bypasses comment-already-posted idempotency for a row that prior succeeded with comment but lost cache

lowmaintainabilitylow
  • apps/web/lib/review-worker.ts:211-220
If a row reaches processClaimedRow with files.length===0 we mark it succeeded — but this code path overwrites filesReviewed and providerResponses on a row that might have been partially updated by a previous attempt. Since the early gates check prCommentId !== null before claiming, this is mostly safe; but updateReview clobbers fields without an idempotency check. Minor maintainability issue.

Recommendation

Consider scoping the updateReview to only write fields when prior state is pending/empty.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.