AntFleet

Disagreement · 52c1a3b9-anthropic-5

after() webhook handlers swallow errors silently for install/installation_repositories

solo Opus
repo e24ef98c·PR #11·reviewed 1 week ago

Opus finding

after() webhook handlers swallow errors silently for install/installation_repositories

lowbugmedium
  • apps/web/app/api/github/webhook/route.ts:195-215
  • apps/web/app/api/github/webhook/route.ts:218-233
Unlike the issue_comment and pull_request after() blocks which wrap in try/catch and logError, the installation.created and installation_repositories.added handlers do not. A throw in runWelcomeOnInstall for the first welcome aborts the loop, skipping subsequent welcomes silently (no log, no retry). Inconsistent with the pattern used elsewhere in the file.

Recommendation

Wrap each iteration in try/catch and logError, matching the pattern used for issue_comment dispatch.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗