AntFleet

Disagreement · 52c1a3b9-openai-3

Missing negative-path tests for error-classification: isTransientError never tested to return false

solo GPT-5
repo e24ef98c·PR #11·reviewed 1 week ago

GPT-5 finding

Missing negative-path tests for error-classification: isTransientError never tested to return false

mediumtest-gaphigh
  • apps/web/lib/review-worker.test.ts
Only true/transient cases are asserted. Without a false case, the unconditional true fallback in isTransientError is not caught, allowing all errors to be treated as transient.

Recommendation

Add tests that assert non-transient errors (e.g., "HTTP 400 Bad Request", "Validation failed", "Unauthorized") return false. Also add an end-to-end worker test asserting immediate terminal failure on a non-transient error.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗