AntFleet

Disagreement · 54ec06bb-openai-2

WorkerOutcome returns constant agreedCount/degraded values, losing useful telemetry

solo GPT-5
repo e24ef98c·PR #11·reviewed 1 week ago

GPT-5 finding

WorkerOutcome returns constant agreedCount/degraded values, losing useful telemetry

lowmaintainabilityhigh
  • apps/web/lib/review-worker.ts:148-154
The worker computes actual agreed findings and degraded status earlier, but the returned outcome always sets agreedCount=0 and degraded=false. This can mislead downstream metrics or logging if these fields are ever consumed beyond the current tests.

Recommendation

Return the real agreedCount (bundle.agreed.length) and degraded flag (bundle.degraded) from runReviewWorker’s success path.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →