AntFleet

Disagreement · 5a1afff9-anthropic-0

Empty CAMPAIGN_FILES/ADSET_FILES skip is bypassed when only one subdir is missing, causing 'unbound variable' under set -u

solo Opus
repo 6f7fc663·PR #33·reviewed 1 week ago

Opus finding

Empty CAMPAIGN_FILES/ADSET_FILES skip is bypassed when only one subdir is missing, causing 'unbound variable' under set -u

lowbugmedium
  • scripts/postprocess-admanage-create.sh:40-48
shopt -s nullglob makes missing globs expand to empty, so this is handled. However if CREATES_DIR exists but neither campaigns/ nor adsets/ subdirectory exists, the early-exit at line 47 will fire correctly. Low-impact.

Recommendation

No change required; noting for completeness.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →