AntFleet

Disagreement · 5bbcd2d3-anthropic-2

DM allowlist falls back to selfE164 silently — comment claims 'self-only' but logs nothing

solo Opus
repo 5149da9d·PR #3·reviewed 2 days ago

Opus finding

DM allowlist falls back to selfE164 silently — comment claims 'self-only' but logs nothing

lowmaintainabilitymedium
  • src/web/inbound/access-control.ts:51-58
When dmPolicy is 'pairing' (the default) and no allowFrom is configured, this sets the effective allowFrom to `[selfE164]`. But `isSelfChat` is computed from `configuredAllowFrom` only, not from this implicit default. Downstream code branches on `isSelfChat` (returned in result) for self-chat semantics; with the implicit self-only default the user may expect self-chat mode but `isSelfChat` will be false. Additionally, `isSamePhone` already short-circuits via `dmPolicy !== 'open' && !isSamePhone`, so the implicit self default appears redundant — making the intent unclear.

Recommendation

Either derive isSelfChat from the effective allowFrom (combined + default), or remove the redundant defaultAllowFrom branch since `isSamePhone` already covers DM-to-self. Document the precedence clearly.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗