AntFleet

Disagreement · 6e0f16bf-anthropic-8

BUILDER_CODE / POLYGON_PRIVATE_KEY / POLYMARKET_WALLET_ADDRESS accessed via os.environ[...] inside lru_cached factory

solo Opus
repo 703f69ec·PR #2·reviewed 5 days ago

Opus finding

BUILDER_CODE / POLYGON_PRIVATE_KEY / POLYMARKET_WALLET_ADDRESS accessed via os.environ[...] inside lru_cached factory

lowapi-contracthigh
  • agent/tools/markets.py:71-102
Missing env vars surface as KeyError with no actionable message. Because get_clob_client is lru_cached, the failure is not retried and the cache stays empty (the exception simply re-raises on each call, but the message gives no hint which env var the operator forgot). Minor DX issue but trivial to fix.

Recommendation

Use os.environ.get(...) and raise a descriptive RuntimeError listing the missing variable name, or wrap startup in a config validator.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗