AntFleet

Disagreement · 7acb8d8e-anthropic-3

`prepare` script runs `husky` unconditionally, breaking installs in CI/forks without git

solo Opus
repo 53606958·PR #4·reviewed 1 week ago

Opus finding

`prepare` script runs `husky` unconditionally, breaking installs in CI/forks without git

mediumbuild-releasemedium
  • package.json:14
`prepare` runs on every `npm install`, including in environments without a `.git` directory (Docker builds, `npm ci --omit=dev` paths that still trigger prepare in dev installs, sandboxed agent runners). Bare `husky` (v9) will error or silently misconfigure when there is no git repo. Given this is a template forked per-agent and run inside autonomous agent containers, this can break bootstrap. The conventional pattern is `husky || true` or `husky install` gated on git presence.

Recommendation

Guard the prepare script, e.g. `"prepare": "husky || true"` or detect `.git` existence first; or move husky setup behind an explicit setup script.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →