AntFleet

Disagreement · 7cad6f1a-anthropic-9

NoOpGovernanceFactory duplicates DEAD_ADDRESS instead of importing the shared constant

solo Opus
repo a7cc2ed7·PR #3·reviewed 1 week ago

Opus finding

NoOpGovernanceFactory duplicates DEAD_ADDRESS instead of importing the shared constant

lowmaintainabilityhigh
  • src/governance/NoOpGovernanceFactory.sol:12-14
  • src/governance/LaunchpadGovernanceFactory.sol:5-6
`LaunchpadGovernanceFactory` imports `DEAD_ADDRESS` from a shared constants file but `NoOpGovernanceFactory` redefines its own. Risk of divergence (e.g., if the shared constant is changed to a different sentinel, NoOpGovernanceFactory would silently disagree).

Recommendation

Import `DEAD_ADDRESS` from `src/types/Constants.sol` in NoOpGovernanceFactory.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →
← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗