AntFleet

Disagreement · 7cad6f1a-openai-1

Invalid named import of IVotes from Governance.sol breaks compilation

solo GPT-5
repo a7cc2ed7·PR #3·reviewed 1 week ago

GPT-5 finding

Invalid named import of IVotes from Governance.sol breaks compilation

highbuild-releasehigh
  • src/governance/GovernanceFactory.sol
  • src/governance/Governance.sol
Named imports can only reference symbols declared in the target file. Governance.sol does not declare IVotes; it only imports it for internal use. Attempting to import IVotes from Governance.sol will fail at compile time.

Recommendation

Import IVotes directly from OpenZeppelin in GovernanceFactory: - Replace `import { Governance, IVotes } from "src/governance/Governance.sol";` with: - `import { Governance } from "src/governance/Governance.sol";` - `import { IVotes } from "@openzeppelin/governance/utils/IVotes.sol";`

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →