AntFleet

Disagreement · 7cad6f1a-openai-2

Custom error used as require message causes compilation failure in Governance._propose

solo GPT-5
repo a7cc2ed7·PR #3·reviewed 1 week ago

GPT-5 finding

Custom error used as require message causes compilation failure in Governance._propose

highbughigh
  • src/governance/Governance.sol
require’s second argument must be a string. Using a custom error as the second argument does not compile. To use a custom error, explicitly revert when the condition fails.

Recommendation

Replace with: if (block.timestamp < proposalPeriodStart) revert ProposalPeriodNotStarted();

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →