AntFleet

Disagreement · 89395cd4-anthropic-0

dry-run var parsing breaks for 'dry-run owner/repo' override syntax

solo Opus
repo 6f7fc663·PR #21·reviewed 1 week ago

Opus finding

dry-run var parsing breaks for 'dry-run owner/repo' override syntax

mediumbughigh
  • skills/contributor-spotlight/SKILL.md:50-53
Step 1 says: strip the `dry-run` prefix and treat the remainder as a possible owner/repo. But the owner/repo regex `^[a-zA-Z0-9._-]+/[a-zA-Z0-9._-]+$` is anchored and won't tolerate a leading space/separator between `dry-run` and `owner/repo`. The spec is silent on what separator the operator should use (`dry-run owner/repo`, `dry-run:owner/repo`, etc.) and the regex match is against `$var` rather than the stripped remainder (`OVERRIDE_FORK=$var`, not `$remaining`). So any operator who passes `dry-run owner/repo` will (a) not match owner/repo (leading 'dry-run ' breaks the anchor) and (b) hit the SPOTLIGHT_BAD_VAR branch, exiting without writing the article — contradicting the table claim that dry-run still writes article+history.

Recommendation

Specify exactly how to split the var (e.g. tokenize on whitespace; first token may be `dry-run`, second token is the optional owner/repo override). Match the regex against the stripped remainder, not `$var`. Add a fixture-style example in the doc.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.