AntFleet

Disagreement · 89395cd4-anthropic-2

FORK_DEFAULT_BRANCH used before being set

solo Opus
repo 6f7fc663·PR #21·reviewed 1 week ago

Opus finding

FORK_DEFAULT_BRANCH used before being set

mediumbughigh
  • skills/contributor-spotlight/SKILL.md:125-130
  • skills/contributor-spotlight/SKILL.md:108-113
Step 5 references `${FORK_DEFAULT_BRANCH}` in the gh api call, but Step 4 wrote `default_branch` into /tmp/contrib-repo.json as JSON and never extracted it into a shell variable. With nounset or just an empty expansion, `?ref=` becomes empty, so gh defaults to the repo's default branch — which usually works but silently does the wrong thing if the operator's work is on a non-default working branch they've set as default later, or if the JSON parse fails. More importantly, the spec is internally inconsistent: it tells the implementer to use a variable that the spec never assigns.

Recommendation

Add an explicit `FORK_DEFAULT_BRANCH=$(jq -r .default_branch /tmp/contrib-repo.json)` (with a fallback to `main`) between Step 4 and Step 5, or drop the `?ref=` parameter entirely since gh defaults to the default branch.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.