AntFleet

Disagreement · 89395cd4-openai-3

Variables referenced in article/notification templating are never set (stars, html_url, cohort, days_since_run, contributor logins)

solo GPT-5
repo 6f7fc663·PR #21·reviewed 1 week ago

GPT-5 finding

Variables referenced in article/notification templating are never set (stars, html_url, cohort, days_since_run, contributor logins)

mediumbughigh
  • skills/contributor-spotlight/SKILL.md
  • skills/contributor-spotlight/SKILL.md
  • skills/contributor-spotlight/SKILL.md
  • skills/contributor-spotlight/SKILL.md
  • skills/contributor-spotlight/SKILL.md
The template uses ${stars}, ${html_url}, ${days_since_run}, ${cohort}, and contributor logins without prior assignment from the fetched JSON/state. While the repo JSON is written to /tmp/contrib-repo.json, no step translates these fields into shell variables. Similarly, days_since_run and cohort are referenced but not extracted from the state/article.

Recommendation

Extract required fields with jq, e.g.: stars=$(jq -r '.stars // 0' /tmp/contrib-repo.json); html_url=$(jq -r '.html_url // ""' /tmp/contrib-repo.json). Resolve cohort and days_since_run from the chosen source (COHORT_STATE or COHORT_ARTICLE) for the FEATURED_FORK. Parse top contributors from /tmp/contrib-top.json into rows.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.