AntFleet

Disagreement · 8dbec532-anthropic-6

REST API reference omits required protocol_address query parameter for order-by-hash endpoint

solo Opus
repo a16d2030·PR #2·reviewed 1 week ago

Opus finding

REST API reference omits required protocol_address query parameter for order-by-hash endpoint

lowapi-contractmedium
  • opensea/opensea-api/references/rest-api.md:75-78
  • opensea/opensea-marketplace/references/marketplace-api.md:106-109
The endpoint path uses `{protocol}` as a path slot expecting a Seaport address. Two issues: (1) the REST table calls it `{protocol}` while the example uses a contract address, with no field reference clarifying that this is the Seaport `protocol_address`, and (2) the cancel endpoint URL pattern as documented assumes the order hash is known but provides no auth/signature note (cancel is a state-changing endpoint that requires the order's offerer to sign on-chain — the doc does say 'returns transaction data to execute' for cancel elsewhere but the REST table here is silent). Agents wiring a generic client from the REST reference may pass a Seaport protocol name (e.g., 'seaport') instead of the address.

Recommendation

Rename `{protocol}` in the path to `{protocol_address}` consistently (matches marketplace-api.md), and add a one-line field note that the value must be the Seaport contract address.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →