AntFleet

Disagreement · 8ff8c1af-anthropic-8

Telemetry singleton constructs DB synchronously in module import path with side effects

solo Opus
repo 56f59a0d·PR #2·reviewed 4 days ago

Opus finding

Telemetry singleton constructs DB synchronously in module import path with side effects

lowmaintainabilityhigh
  • src/providers/telemetry.ts:60-73
Calling getInstance() creates a real ~/.mythos-router directory, opens a SQLite handle, and registers process.on('exit'/'beforeExit') listeners. Repeated process.on listeners in long-running test suites or REPLs can leak; the constructor also assumes a writable home directory (will throw on read-only environments like serverless / certain Docker images). No try/catch around fs.mkdirSync or DB construction means import-time crash propagates as opaque error.

Recommendation

Wrap initialization in try/catch with fallback to in-memory DB or no-op store; document HOME requirement.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.