AntFleet

Disagreement · a2392d54-anthropic-1

EventStream React key collision when same finding appears as both 'agreed' and 'closed'

solo Opus
repo e24ef98c·PR #7·reviewed 2 weeks ago

Opus finding

EventStream React key collision when same finding appears as both 'agreed' and 'closed'

lowbugmedium
  • apps/web/app/activity/ActivityView.tsx:326-332
  • apps/web/app/activity/ActivityView.tsx:343-351
Key includes event.kind so agreed vs closed of the same findingId differ. However, if the backend ever emits two `finding_agreed` rows with the same findingId and ts (e.g., two reviewers both produce identical timestamps, or de-dupe failure), React will warn about duplicate keys. Low-severity / defensive; not a hard bug given current schema assumptions.

Recommendation

Consider including a stable monotonic id from the DB row in FleetActivityEventJson so keys are guaranteed unique without depending on ts uniqueness.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →
← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗