GPT-5 finding
Redundant conditional when building receipt link in EventRow
lowmaintainabilityhigh
- apps/web/app/activity/ActivityView.tsx:411-415
- apps/web/app/activity/ActivityView.tsx:24-27
Both "finding_agreed" and "finding_closed" variants have a findingId, so the inner ternary in the href construction is unnecessary. This adds noise and can mask future errors if one branch were to diverge unintentionally.
Recommendation
Simplify the href construction to: const href = event.kind === "review_completed" ? null : `/receipts/${encodeURIComponent(event.findingId)}`;