AntFleet

Disagreement · b6cf244f-openai-3

Docs claim signals cannot be published for nonexistent trades, but publish-signal.sh allows unverified publishing

solo GPT-5
repo a16d2030·PR #5·reviewed 1 week ago

GPT-5 finding

Docs claim signals cannot be published for nonexistent trades, but publish-signal.sh allows unverified publishing

highdocs-gaphigh
  • bankr-signals/SKILL.md:138-141
  • bankr-signals/scripts/publish-signal.sh:68-71
The implementation explicitly allows publishing when transaction verification fails. This directly contradicts the documentation, weakening trust in the signal feed and potentially enabling fake signals.

Recommendation

Change default behavior to abort on unverifiable TX unless explicitly overridden by a flag (e.g., --allow-unverified). Update docs accordingly if unverified publishing is permitted, or implement required verification to match current docs.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.