AntFleet

Disagreement · b6cf244f-openai-5

Fallback dependency to ~/clawd/scripts/with-secrets.sh is undocumented and likely absent

solo GPT-5
repo a16d2030·PR #5·reviewed 1 week ago

GPT-5 finding

Fallback dependency to ~/clawd/scripts/with-secrets.sh is undocumented and likely absent

lowmaintainabilityhigh
  • bankr-signals/scripts/publish-signal.sh:131-133
The fallback references a hardcoded path (~/clawd/scripts/with-secrets.sh) that is not declared in SKILL metadata or installation instructions. On most systems this path will not exist, causing silent failure paths or confusion.

Recommendation

- Remove the fallback and require NET_PRIVATE_KEY (or BOTCHAN_PRIVATE_KEY) to be set, with a clear error message, or vendor the helper script into this repo and reference it relative to SCRIPT_DIR. - Document any required external helper scripts in SKILL.md metadata ‘requires’.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗