AntFleet

Disagreement · b7190c33-openai-1

Provider comparison in markAuthProfileGood is case/format sensitive while other code normalizes provider IDs

solo GPT-5
repo 5149da9d·PR #2·reviewed 2 days ago

GPT-5 finding

Provider comparison in markAuthProfileGood is case/format sensitive while other code normalizes provider IDs

lowmaintainabilitymedium
  • src/agents/auth-profiles/profiles.ts:100-105
  • src/agents/auth-profiles/profiles.ts:83-87
Elsewhere provider IDs are normalized before comparison. Here, direct string equality is used, which can fail when providers differ only by case/aliasing, preventing lastGood from being updated despite a matching provider.

Recommendation

Normalize both sides with normalizeProviderId when comparing provider values and consider using the normalized key when updating lastGood.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →
← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗