AntFleet

Disagreement · bdb225d0-anthropic-3

RSS lastBuildDate fallback uses `new Date()` when both feeds are empty — defeats Cache-Control freshness

solo Opus
repo e24ef98c·PR #10·reviewed 1 week ago

Opus finding

RSS lastBuildDate fallback uses `new Date()` when both feeds are empty — defeats Cache-Control freshness

lowbugmedium
  • apps/web/app/receipts.rss/route.ts:57-67
When there are no receipts at all, lastBuildDate is set to `new Date()` (request time). Combined with `Cache-Control: public, max-age=300, s-maxage=300`, the feed body changes (lastBuildDate moves) on every fresh edge fetch, but RSS readers that cache by lastBuildDate may see a 'new' feed every 5 minutes despite no actual content change. Minor — more annoying than incorrect — but readers may show spurious updates on Slack /feed.

Recommendation

When both feeds are empty, use a fixed epoch (e.g., a build-time constant) or omit lastBuildDate.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →