AntFleet

Disagreement · bdb225d0-anthropic-4

Onboarder error path stamps onboarderResult with zeros but reported as `onboarder` in success response — masks partial failure to API consumers

solo Opus
repo e24ef98c·PR #10·reviewed 1 week ago

Opus finding

Onboarder error path stamps onboarderResult with zeros but reported as `onboarder` in success response — masks partial failure to API consumers

lowapi-contracthigh
  • apps/web/app/api/cron/sweep/route.ts:56-75
If runDailyOnboarderCheckIns throws, the JSON response includes onboarder: {attempted:0, posted:0, skipped:0, errors:0}, which is indistinguishable from a successful no-op run. Consumers (dashboards, alerts) parsing the response can't tell that the onboarder failed entirely vs ran with nothing to do. Logged but not surfaced in the structured response.

Recommendation

Add an `ok: boolean` or `error: string | null` field to onboarderResult on the catch path so the response distinguishes the two cases.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →