AntFleet

Disagreement · c9663187-anthropic-19

SocialAgent class-level mutable `_extra_body_logged` flag — module-wide, not per-instance

solo Opus
repo 193af03f·PR #2·reviewed 1 week ago

Opus finding

SocialAgent class-level mutable `_extra_body_logged` flag — module-wide, not per-instance

lowmaintainabilityhigh
  • backend/wonderwall/social_agent/agent.py:210-219
`SocialAgent._extra_body_logged = True` sets a class attribute that persists for the lifetime of the Python process. Across multiple simulations in the same process (e.g., test suites), only the first agent ever logs the debug warning. This is fine for the intended purpose, but using class-level mutable state is brittle and not thread-safe.

Recommendation

Either gate by a module-level threading.Event or remove the warning once stable.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →