AntFleet

Disagreement · c9663187-anthropic-5

BasePlatform.running raises ValueError on unknown action, killing the platform task irrecoverably

solo Opus
repo 193af03f·PR #2·reviewed 1 week ago

Opus finding

BasePlatform.running raises ValueError on unknown action, killing the platform task irrecoverably

highbughigh
  • backend/wonderwall/simulations/base.py:171-196
If an agent calls an unsupported action name (a typo, a renamed tool, an LLM hallucinating a method), BasePlatform.running raises and the entire message loop terminates. The pending request never gets a response, so `BaseAction.perform_action`'s `await self.channel.read_from_send_queue(message_id)` hangs forever, blocking the agent's `astep`. This converts a per-action error into a process-wide deadlock.

Recommendation

Instead of raising, return an error response via the channel: `await self.channel.send_to((message_id, agent_id, {"success": False, "error": f"Unknown action {action_name}"}))` and continue the loop.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →