GPT-5 finding
Abstract Environment.to_text_prompt is sync while implementations are async, creating a confusing interface contract
lowmaintainabilityhigh
- backend/wonderwall/social_agent/agent_environment.py:36-39
- backend/wonderwall/social_agent/agent_environment.py:130-136
The abstract base method is declared synchronous but overridden as async in SocialEnvironment, and callers await it. This mismatch can confuse implementers and type checkers, and it weakens the contract enforced by the ABC.
Recommendation
Change the abstract method to be async def to_text_prompt(self) -> str in the Environment base class so subclasses and callers consistently use an async interface.