AntFleet

Disagreement · cdf9ffa0-anthropic-9

summary_lines array may overflow notify length budget; SKILL.md mentions 2000-char limit for aixbt but postprocess scripts don't truncate

mismatch
repo 6f7fc663·PR #4·reviewed 1 week ago

Primary finding

summary_lines array may overflow notify length budget; SKILL.md mentions 2000-char limit for aixbt but postprocess scripts don't truncate

lowmaintainabilitymedium
  • scripts/postprocess-admanage-create.sh:166-178
If a large batch is queued (e.g., 50 ad sets), the summary may exceed Telegram/Discord/Slack message limits. The aixbt skill documents this limit (2000 chars), but the postprocess scripts don't. This will silently fail or truncate inconsistently across channels. Low-severity since file artifacts exist, but worth bounding.

Recommendation

Cap summary_lines length, append '...and N more' if exceeded, and rely on the results/ files for full detail.

Counterpart finding

State file updates are not synchronized; concurrent runs can clobber each other

lowconcurrencymedium
  • scripts/postprocess-admanage-create.sh:102-107
  • scripts/postprocess-admanage-create.sh:166-171
Two instances running in parallel (e.g., separate queues or retries) can both read the same STATE_FILE, each compute a new version, and the last mv wins, dropping the other's updates. While the pipeline likely runs one postprocess at a time, the code has no locking to prevent lost updates.

Recommendation

Use a file lock (flock) around state read-modify-write sections or perform updates via jq with in-place atomic append guarded by a lock file. Alternatively, serialize via CI or ensure the workflow prevents concurrent invocations.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗