AntFleet

Disagreement · d8976a54-anthropic-5

goals.json missing a top-level schema/version marker but is consumed by multiple skills

solo Opus
repo 53606958·PR #2·reviewed 1 week ago

Opus finding

goals.json missing a top-level schema/version marker but is consumed by multiple skills

lowmaintainabilitymedium
  • memory/goals.json:1-33
goals.json is read by both build.md (gate check on `.mode`) and heartbeat.md (milestone progress, mode update writes). There is no `schemaVersion` and no JSON schema referenced; any future renaming of `mode` or `milestones[0].current` will break consumers silently. heartbeat.md already accesses `g.milestones[0].current` positionally, which will silently report wrong data if the array order changes (e.g., the build-launchpad milestone is reordered to index 0).

Recommendation

Either look up the milestone by id (`milestones.find(m => m.id === 'accumulate-100-diem')`) or add a `schemaVersion` and a stable accessor convention, and validate in CI.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.