AntFleet

Disagreement · d8976a54-anthropic-6

Build skill commits code without running tests, only typecheck

mismatch
repo 53606958·PR #2·reviewed 1 week ago

Primary finding

Build skill commits code without running tests, only typecheck

mediumtest-gaphigh
  • .claude/skills/build.md:42-48
  • .claude/skills/build.md:33-40
The per-tick execution loop runs `npm run typecheck` then commits with `git add -A`. For a launchpad that handles wallet connections, ERC-20 approvals, and on-chain vault deployments with depositors' funds, type-only validation is insufficient — runtime bugs (e.g., wrong ABI encoding, wrong decimal handling) will pass typecheck and ship. Additionally `git add -A` indiscriminately stages every modified file, which can leak local state (e.g., .env, build artifacts) into commits.

Recommendation

Add `npm test` (and a lint/format gate) to the per-tick pipeline; replace `git add -A` with explicit paths or a precommit hook that refuses to stage untracked files outside the launchpad workspace.

Counterpart finding

Inconsistent reference path for MintDiemPresaleVault.sol across docs

mediumdocs-gaphigh
  • .claude/skills/build.md:31
  • memory/goals.json:23
Two different paths are provided for the same contract reference. One includes a repository prefix (liquid-protocol-v0/), the other does not. This will cause confusion for implementers following the build plan or browsing techRef, slowing work or causing mistaken edits in the wrong location.

Recommendation

Standardize the path in both places. If the contract lives in an external repo, include the full repository path (or a URL) consistently; if it is vendored locally, remove the external prefix and ensure the file exists here. Consider replacing paths with clickable links to the canonical source.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗