Disagreement · d9ae4fa5-anthropic-4

deterministic mode still iterates remaining candidates after first failure instead of failing fast

solo Opus

repo 56f59a0d·PR #3·reviewed 4 days ago

Opus finding

deterministic mode still iterates remaining candidates after first failure instead of failing fast

mediumbughigh

src/providers/orchestrator.ts:200-220
src/providers/orchestrator.ts:440-460

selectProvider returns a single candidate for deterministic mode, so the deterministic-mode check in catch is technically reached only on that single candidate (and throws). That's fine, but the comment 'Deterministic mode: don't fallback (except hard 5xx)' is misleading — there is no hard-5xx exception; it always throws. The deceptive comment may lead callers to believe deterministic mode falls back on 5xx, which it does not.

Recommendation

Either implement the documented 5xx-fallback behavior or correct the comment to 'never falls back'.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreements view public receipts see unanimous findings + anatomies →

Tweet ↗