AntFleet

Disagreement · d9ae4fa5-openai-1

Watchdog timer is not cleared on error/fallback, leaking a pending timer per attempt

mismatch
repo 56f59a0d·PR #3·reviewed 4 days ago

Primary finding

Watchdog timer is not cleared on error/fallback, leaking a pending timer per attempt

mediumbughigh
  • src/providers/orchestrator.ts:391-409
  • src/providers/orchestrator.ts:431-433
  • src/providers/orchestrator.ts:514-518
On success, the watchdog timer is cleared. On exceptions/fallback (catch path), the timer is not cleared, leaving a pending timeout that will fire later and abort the now-orphaned controller. This creates dangling timers per failed attempt and unnecessary abort callbacks, wasting resources and complicating debugging.

Recommendation

Clear watchdogTimer in a finally block so it runs on both success and error. Example: move `if (watchdogTimer) clearTimeout(watchdogTimer);` into the finally or ensure it executes before continuing to the next candidate.

Counterpart finding

Watchdog abort-error detection relies on brittle string matching

lowmaintainabilityhigh
  • src/providers/orchestrator.ts:408-416
  • src/providers/orchestrator.ts:46-62
isRetryableError and the watchdog-abort detection both rely on substring matching of localized error messages. This is fragile across Node versions and provider SDKs (e.g. 'AbortError' vs 'aborted'); 'aborted' will also match unrelated messages like 'request aborted by user'. Moreover, the watchdog-abort branch in the catch block has an empty body and a comment but does nothing — dead code.

Recommendation

Use error codes / instanceof checks (err.name === 'AbortError', err.code, err.status). Remove the empty branch or implement the documented behavior.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗