AntFleet

Disagreement · f3aba81f-openai-2

Misleading field name first_seen_below_at despite side possibly being below or above

solo GPT-5
repo 6f7fc663·PR #23·reviewed 1 week ago

GPT-5 finding

Misleading field name first_seen_below_at despite side possibly being below or above

lowdocs-gaphigh
  • skills/price-threshold-alert/SKILL.md:50-55
  • skills/price-threshold-alert/SKILL.md:133
  • skills/price-threshold-alert/SKILL.md:63
The field first_seen_below_at is always recorded regardless of side, but the name suggests it only applies when first seen below the target. This is confusing and error-prone for maintainers.

Recommendation

Rename to first_seen_at (or first_seen_from_side_at) throughout schema, logic, LRU policy, and docs.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →