GPT-5 finding
State write pathway vs. fetch-fail behavior and .bak handling are underspecified/inconsistent
lowmaintainabilitymedium
- skills/price-threshold-alert/SKILL.md:96
- skills/price-threshold-alert/SKILL.md:198-209
- skills/price-threshold-alert/SKILL.md:211
The spec says fetch failure should do “no state mutation beyond touching last_run_at,” but the persist step shows a full-object rewrite requiring multiple variables and mentions restoring from a .bak without specifying when/how the .bak is created. The partial-update path is unclear and can lead to diverging implementations.
Recommendation
Document a minimal write path for failures (only update last_run_at, using the existing JSON as the source), and explicitly define when a .bak is created (e.g., cp before write) and restored.