AntFleet

Disagreement · f5ac807a-anthropic-2

LRU cap on targets uses wrong recency field

solo Opus
repo 6f7fc663·PR #23·reviewed 1 week ago

Opus finding

LRU cap on targets uses wrong recency field

lowbughigh
  • skills/price-threshold-alert/SKILL.md:233-234
`first_seen_below_at` is set once on first observation and never updated. Using it as the LRU key means recency is actually 'order of first appearance', not 'order of most-recent activity' — a target hit yesterday could be evicted before a never-touched target observed two weeks ago. Also, an operator who re-passes the same target via `${var}` does not refresh the timestamp (no spec for that), so re-passed targets get evicted as if abandoned.

Recommendation

Either (a) refresh `first_seen_at` each run the target appears in `${var}`, or (b) use `max(first_seen_at, hit_at, last_observed_at)` as the LRU key. Document the choice explicitly.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.