AntFleet

Disagreement · fc046725-openai-2

Incorrect Next.js route param typing and unnecessary await on params

solo GPT-5
repo 6f7fc663·PR #26·reviewed 1 week ago

GPT-5 finding

Incorrect Next.js route param typing and unnecessary await on params

lowapi-contracthigh
  • dashboard/app/api/runs/[id]/logs/route.ts:24-30
Next.js passes `{ params: { id: string } }` synchronously; typing as Promise and awaiting is incorrect and degrades type safety. While `await` on a non-thenable works at runtime, it’s misleading and invites further misuse.

Recommendation

Change signature to `export async function GET(_request: Request, { params }: { params: { id: string } })` and remove `await` usage.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →